Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CPACS related functions #224

Open
joergbrech opened this issue Mar 14, 2024 · 1 comment
Open

Deprecate CPACS related functions #224

joergbrech opened this issue Mar 14, 2024 · 1 comment

Comments

@joergbrech
Copy link
Contributor

joergbrech commented Mar 14, 2024

Historically, TiXI was intended specifically for handling CPACS files. There are still a few functions in TiXI that are CPACS-specific. Examples for this are tixiAddHeader and tixiAddCpacsHeader. The first one is very old and the second one only works with CPACS < 3.5, see DLR-SL/CPACS#796.

Consequences of removing these functions:

  • TiXI as an xml-handling library is not dependent on a specific xml-schema (namely CPACS)
  • CPACS users must implement their own tixiAddCpacsHeader, which should be doable with just a few lines in TiXI.

@CLiersch, @MarAlder, what do you think?

@MarAlder
Copy link

I have always overlooked this function until now. But I agree with you that this should not be part of TiXI, but part of what I envision as a low-level cpacsLibrary.

I have already practiced this with some users of the community in their corresponding codes, writing the header with the usual createElement methods. Its simple enough.

Instead of updating the function, I would therefore remove it from TiXI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants