Dereference of an uninitialized boost::optional in rotors code

[joergbrech]

CPACSRotor::GetNominalRotationsPerMinute() returns a boost::optional<double>&. The return value is dereferenced in several places without first checking if the boost::optional holds a value:

tigl/src/rotor/CCPACSRotor.cpp

Line 220 in ede4575

return *GetNominalRotationsPerMinute() / 30. * M_PI * GetRadius();

tigl/src/rotor/CCPACSRotorBladeAttachment.cpp

Line 84 in ede4575

if (GetRotor().GetNominalRotationsPerMinute() < 0. ) {

tigl/src/rotor/CTiglAttachedRotorBlade.cpp

Line 216 in ede4575

return *GetRotor().GetNominalRotationsPerMinute() / 30. * M_PI * GetRadius();

Suggestion:

I suggest shadowing GetNominalRotationsPerMinute in CCPACSRotor with a wrapper function that returns a double by calling generated::CPACSRotor::GetNominalRotationsPerMinute().get_value_or(0.); This makes sure that the default value for this optional is defined only in one place in the code.