Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching local attr values can raise an exception #381

Open
Cadair opened this issue May 8, 2024 · 0 comments
Open

Fetching local attr values can raise an exception #381

Cadair opened this issue May 8, 2024 · 0 comments
Labels

Comments

@Cadair
Copy link
Member

Cadair commented May 8, 2024

There is an edge case in the attr values code which can happen (I think) in the following case:

  1. Successfully trigger a download of the values to the local data dir.
  2. Attempt to refresh the values but have the download fail.
  3. Error is raised because the failed download has deleted the pre-existing file.

I think this should be reliably triggered by running:

$ python -m dkist.net
$ touch -d "2020/01/01T00:00:00" ~/.local/share/dkist/api_search_values.json
$ tox -e py311

as the tox refresh will fail due to pytest-remotedata.

@Cadair Cadair added the bug label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant