Warning (-Wunknown-pragmas) with gcc 9.2 in Common.h

[phcerdan]

src/DGtal/base/Common.h:48: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
   48 | #pragma clang diagnostic push
      |
src/DGtal/base/Common.h:49: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
   49 | #pragma clang diagnostic ignored "-Wdeprecated-declarations"
      |
In file included from src/tests/topology/testSplitFunctions.cpp:30:
src/DGtal/base/Common.h:53: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
   53 | #pragma clang diagnostic pop
      |

I tried to just push, below the current GCC diagnostic ignored

#pragma GCC diagnostic ignored "-Wunknown-pragmas"

but doesn't seem to work.

[rolanddenis]

I get these warnings only if I enable WITH_QGLVIEWER (and also for older versions of GCC, 7 & 8)... same for you?

[phcerdan]

Yes! I have WITH_QGLVIEWER enabled. I should re-check if I get these in gcc10.

[rolanddenis]

I should have checked the code before: these pragma are parsed only if WITH_QGLVIEWER is set: https://github.com/DGtal-team/DGtal/blob/master/src/DGtal/base/Common.h#L45 😅

[rolanddenis]

Clang is supposed to support the #pragma GCC but I don't know if XCode behaves differently... @dcoeurjo can you check on your side after removing the #pragma clang?

[rolanddenis]

Yes! I have WITH_QGLVIEWER enabled. I should re-check if I get these in gcc10.

Same warnings in GCC 10.1 (BTW thanks for the information that v10 was released 😉 )