Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message when using deathcause on vermin #4513

Closed
myk002 opened this issue Apr 25, 2024 · 2 comments · Fixed by DFHack/scripts#1091
Closed

better error message when using deathcause on vermin #4513

myk002 opened this issue Apr 25, 2024 · 2 comments · Fixed by DFHack/scripts#1091

Comments

@myk002
Copy link
Member

myk002 commented Apr 25, 2024

right now it's a stack trace' should be an explanatory message

@xBlackTalonX
Copy link
Contributor

Much better than a stack trace! More minor feedback:
A) Selecting dead vermin within a dump of body parts (unit gui open) and running deathcause results in,
"Automatically chose first corpse at selected location. The horse died."

B) Placing the keyboard cursor on that same stack of body parts and running deathcause results in,
"deathcause: Please select a corpse"

C) Clicking the stack of body parts beings up a UI screen "item list" (I don't know if there is a common reference to this screen) and then running deathcause (with "item list" gui open) results in,
"deathcause: Please select a corpse"

D) Selecting the horse hair item in this list (item gui open),
"The horse died"

E) Selecting an item (toy boat) (item gui open),
"deathcause: Please select a corpse"

F) Selecting a living creature (pig) (unit gui open),
"The pig is not dead yet!"

G) Selecting dead vermin (rat) isolated on a tile (item gui open),
"deathcause: Please select a corpse"

H) Selecting a living creature standing on top of a pile of body parts and vermin (unit gui open),
"[unit] is not dead yet!"

I) Selecting an item (toy boat)(item gui open) in a stack of body parts and living creatures,
"Automatically chose first corpse at selected location. The horse died."

So ideally,

  • B and C should have the result of A: stack of items selected with cursor or gui item list would report that the first corpse in the stack was selected. (or output a line for each item in the stack)
  • A (and presumably G) would have the result of D: dead vermin 'remains' would just say, "The [vermin] died," since no further information is really needed to have that limited detail.
  • Alternatively, vermin could trigger a message like F, "[vermin] cause of death unsupported" but then that message would seemingly also be appropriate in cases like D (the horse hair).

But this is all really minor stuff so probably not worth more time?

@myk002
Copy link
Member Author

myk002 commented Apr 30, 2024

done in DFHack/scripts#1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants