Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any plans for supporting salvo? #55

Closed
shujaatak opened this issue Nov 29, 2023 · 5 comments · Fixed by #96
Closed

Any plans for supporting salvo? #55

shujaatak opened this issue Nov 29, 2023 · 5 comments · Fixed by #96
Labels
enhancement New feature or request question Further information is requested

Comments

@shujaatak
Copy link

Wondering if there are plans for supporting other frameworks specially salvo?
@DDtKey
Copy link
Owner

DDtKey commented Nov 29, 2023 •
edited

Hi @shujaatak,
There are plans to cover a couple more frameworks.

I'll have to do some research on salvo before giving a final answer. But I'll be happy to add it to the list.
Also anyone wishing to contribute is welcome!

Thanks for the question!

@DDtKey DDtKey added enhancement New feature or request question Further information is requested labels Nov 29, 2023
@DDtKey
Copy link
Owner

DDtKey commented Nov 29, 2023 •
edited

Looks like it's technically not that hard to support salvo

@DDtKey
Copy link
Owner

DDtKey commented Dec 8, 2023 •
edited

Just to keep informed:
support for salvo and axum is on the way, they will actively reuse code since they are both tower compatible.

UPD: my bandwidth has been limited for a while, sorry for the delay, but support will definitely be here!

@DDtKey DDtKey mentioned this issue Mar 9, 2024
Merged
2 tasks
@DDtKey
Copy link
Owner

DDtKey commented Apr 10, 2024 •
edited

Initial version of axum support is released (but will be changed a bit later).

Salvo is next, already in progress and will reuse core functionality, however requires a little bit more time because of the specific.

@DDtKey DDtKey mentioned this issue May 29, 2024
Merged
2 tasks
@DDtKey
Copy link
Owner

DDtKey commented May 29, 2024

Finally here we are 😅
salvo is supported now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support salvo DDtKey/protect-endpoints
2 participants
@shujaatak @DDtKey