-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is what XXH_64 in modern C++11 looks like #86
Comments
This is a great piece of code, though I don't know where it would be best displayed. |
eh, I don't know how important it is to keep it open - people can always search the Closed issues (and I believe they show up on Google searches). My thinking for posting it, is for anyone who might want to integrate xxHash in a header-only library. I think its safe to close, thanks! |
zlib, for example, has the subdir "contrib" that includes 3rd-party modules improving various library aspects, w/o support from zlib developers. what about doing the same? |
@Bulat-Ziganshin That's up to @Cyan4973 but consider this, if we put it in contrib/ then it needs unit tests, build scripts, and some sort of continuous integration otherwise it will be subject to bit-rot. And how would it be maintained? That's why I posted it as an issue comment instead of a pull request. |
The text was updated successfully, but these errors were encountered: