Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countup shortcode counts up to wrong number #637

Closed
kevincrafts opened this issue Jul 28, 2020 · 0 comments · Fixed by #719
Closed

Countup shortcode counts up to wrong number #637

kevincrafts opened this issue Jul 28, 2020 · 0 comments · Fixed by #719
Assignees
Labels
bug Something isn't working deprecate Find and resolve usage in the code base

Comments

@kevincrafts
Copy link
Member

Depending on the number that you use in the countup shortcode (animated count from 0 to given number), the resulting number is 1 less than the number provided. For instance, using the number 230, the counter stops at 229.

https://www.colorado.edu/career/data-dashboard

This doesn't happen with all numbers and seems to have been an issue with this library, which is now very outdated:
bfintal/Counter-Up#75
bfintal/Counter-Up#62
bfintal/Counter-Up#47
bfintal/Counter-Up#36

This library has long since been abandoned, so perhaps it's time to look for something new. If we want to keep this, one work around may be exposing the time value (the time it takes to count), as it seems changing that from the default (2000ms) fixes some numbers.

@jwfuller jwfuller added bug Something isn't working deprecate Find and resolve usage in the code base labels Jul 28, 2020
@AlanBCole AlanBCole self-assigned this Sep 22, 2020
jwfuller added a commit that referenced this issue Sep 29, 2020
Fix for counter.js used in the countup shortcode. Resolves #637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecate Find and resolve usage in the code base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants