Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attribute via entity form results in incorrect entity file #48

Open
harmen-xb opened this issue Feb 28, 2024 · 1 comment
Open

Comments

@harmen-xb
Copy link
Contributor

When adding a new attribute using the entity form/property view the new attribute is created, but doesn't have an Id, so there is an error that the Id is missing.

Steps to reproduce

  1. Open the form editor on an entity
  2. Add an attribute to the entity on the 'Attributes' tab

Expected behaviour
The Id should be in the form for now, maybe automatically populated based on the name?

@harmen-xb
Copy link
Contributor Author

We would like to solve this issue genericly for all objects.

Ideally all objects have a Name and an Id. When a new object is created the Id is initially derived from the Name with:
Id = (replace whitespace with underscore and special charachters with closes ANSI character. For example replace á with a.)

When the name is changed, the Id is NOT changed. This way anyrhing referencing the object is not broken.

In the future we can add logic to refactor the Id's if modellers want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant