Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch task for yarn generate-translations #93

Open
henrytao-me opened this issue Jun 4, 2020 · 3 comments
Open

Add watch task for yarn generate-translations #93

henrytao-me opened this issue Jun 4, 2020 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@henrytao-me
Copy link
Member

What

Currently, we need to run yarn generate-translations every time we change translations folder src/locale/translations/ and commit the compiled file. It would be better to:

  • Add a watch task to automatically generate it.
  • Ignore compiled file on git to prevent PR conflicts.
@henrytao-me henrytao-me added the help wanted Extra attention is needed label Jun 4, 2020
@ChrisDryden
Copy link

I am going to take a crack at this following this tutorial: https://flaviocopes.com/package-json-watch/

Is this example what you were thinking of?

@henrytao-me
Copy link
Member Author

That's the way to go. Go for it. 🙇

@henrytao-me
Copy link
Member Author

I will leave the translation issues to you then @ChrisDryden. Thanks so much. I will take the bluetooth one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants