Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot close the shield when VO is on #169

Open
JuliannaR opened this issue Jun 29, 2020 · 1 comment
Open

Cannot close the shield when VO is on #169

JuliannaR opened this issue Jun 29, 2020 · 1 comment

Comments

@JuliannaR
Copy link

JuliannaR commented Jun 29, 2020

Accessibility

Scenario to reproduce

Then the shield is open you cannot double tap on the arrow in the right corner to close, no gesture allows you to change screens. Tapping near the arrow opens the how it works screens.

Expected result

To be able to close the shield and return to the content underneath.

Bug or issue / WCAG

2.5.1: Pointer Gestures
https://www.w3.org/WAI/WCAG21/Understanding/pointer-gestures.html

Screenshots available

Cannot close the shield when VO is on

Device + OS

iPhone 8 | 13.5.1

@henrytao-me
Copy link
Member

Note: the reason for this is here https://github.com/CovidShield/mobile/blob/master/src/components/BottomSheet/SheetContentsContainer.tsx#L24. SheetContentsContainer wraps all BottomSheet content (both collapsed and expanded content) in a TouchableHighlight with accessibility in it. This setup works for Android but not iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants