Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global] Does not support landscape orientation #11

Open
svinkle opened this issue May 22, 2020 · 6 comments
Open

[Global] Does not support landscape orientation #11

svinkle opened this issue May 22, 2020 · 6 comments

Comments

@svinkle
Copy link
Member

svinkle commented May 22, 2020

Issue summary

The app doesn't seem to support landscape orientation on Android devices. On iOS, it's partially supported though some text nodes are not visible.

Supporting landscape orientation is important for people who prefer one orientation to another. Some may not have the physical capability of making an adjustment to their device. Supporting only portrait mode could lead to a frustrating user experience.

Screen Shot 2020-05-22 at 3 37 53 PM

Screen Shot 2020-05-22 at 3 38 15 PM

Steps to reproduce

  1. Install the CovidShield apk on an Android device
  2. Load the app
  3. Adjust to landscape orientation

Behavior

Expected

  • Content to adjust to landscape mode, allowing full use of the app.

Actual

  • App does not switch to landscape mode.

Recommendation

Allow any orientation. Ensure app content, layout, and controls are accessible when switching device orientation.

Specifications

  • Component: CovidShield [Global]
  • WCAG Principle: Perceivable
  • WCAG SC: 1.3.4 Orientation
  • Severity: High
  • Effort: Unknown
@adam-poteralowicz
Copy link

Could I take on that issue?

@AdamWhitcroft
Copy link

AdamWhitcroft commented May 27, 2020

Recommendations for better landscape support.

  • iPhone X mocks
  • iPhone SE mocks (coming)

Onboarding screens, steps 1 and 2

1

Frame 108

2

Frame 109

Onboarding, learn how

In order to maximise screen real-estate for written content, I'm proposing we drop the animations from these slides. Including them would mean either putting it above or below the text. Above would push the content out of view, and below means you might not even know they are there.

3

Frame 108

4

5

Thank you screen

Sheet button 400pt wide.

6

Frame 108

Home, No exposure detected

Frame 105

Frame 108

Home, Sheet shown

Frame 105

Frame 108

Home, Sheet callout

Use a 24pt "safe space" at the top of the content area to keep header and content visually distinct.

Frame 105

Frame 108

Home, Potentially exposed / thank you / upload reminder

Keeping the animations these two scenarios comes at a significant cost. The main Call To Action for each stage may well be pushed completely out of view. If we feel strongly the animations are important in this orientation, we should render an alternative (smaller) version of them).

Button 400pt wide.

Frame 105

Frame 108

And without animation (my preference).

Frame 105

Frame 108

Home, High alert

Frame 105

Frame 108

Code entry

Frame 105

Frame 108

Code entry, Consent

Frame 105

@henrytao-me
Copy link
Member

henrytao-me commented May 27, 2020

Excellent work @AdamWhitcroft 👍

@kpeatt
Copy link
Member

kpeatt commented May 27, 2020

@AdamWhitcroft Can we possibly keep the animations in the tutorial by going to a columnar layout?

@AdamWhitcroft
Copy link

@kpeatt it might work if we scale down the animations (and maybe re-render them as we have clipping of the echoes on the left and right sides)

Screen Recording 2020-05-27 at 2 35 56 PM

Screen Recording 2020-05-27 at 2 33 10 PM

@kpeatt
Copy link
Member

kpeatt commented May 29, 2020

The above looks good to me.

henrytao-me added a commit that referenced this issue Jun 21, 2020
* Make iOS aware of supported languages

* New animations

* New animations

* Add step 3

* Update AE file

* Remove AE logs

* Revert development team change

* Revert development team change

* remove extra files

* Fix XCode project file

* Fix up extra files and broken XCode project

* Revert "Merge branch 'new-anims' of https://github.com/CovidShield/mobile into new-anims"

This reverts commit 875923e, reversing
changes made to b3712f5.

* Fixes security issue in logkitty 0.6.1 by updating @react-native-community/cli

* Disable application prefix for debug build

* Follow PR fixing package.json

Co-authored-by: Janic Duplessis <janicduplessis@gmail.com>
Co-authored-by: Jordan Good <58042767+jordanAtShopify@users.noreply.github.com>
Co-authored-by: Kyle Peatt <kpeatt@gmail.com>
Co-authored-by: Jordan Good <jordan.good@shopify.com>
Co-authored-by: Henry Tao <henry.tao@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants