Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add Tanstack-Query v5 Support #135

Open
MbBrainz opened this issue Mar 13, 2024 · 9 comments
Open

[feature request] Add Tanstack-Query v5 Support #135

MbBrainz opened this issue Mar 13, 2024 · 9 comments

Comments

@MbBrainz
Copy link

Tanstack query has had a major version upgrade from v4 to v5 and there are some interesting benefits of having v5.

The migration guide to migrate from v4 to v5 can be found here: migrating-to-v5

I'd love to add the feature myself, but i dont have any experience with typescript code generation. The changes itself shouldnt be too hard and if someone wants to implement it or give me a little hint or example on where to start, then please!

@MbBrainz
Copy link
Author

Big libraries in EVM client world have also adopted the Tanstack-Query@v5 for a few months now: https://wagmi.sh/react/guides/migrate-from-v1-to-v2 https://github.com/wevm/wagmi/releases/tag/%40wagmi%2Fcore%402.0.1

@pyramation
Copy link
Collaborator

Thanks! We've put it on our backlog :) will take a look w team asap!

@MbBrainz
Copy link
Author

MbBrainz commented Apr 2, 2024

Im happy to implement and pr, just dont know where to start

@CyberHoward
Copy link

Would be amazing!

@Kayanski
Copy link

This is much needed !

@clydedevv
Copy link

TanStack Query v5 has been looking 👌 would be cool

@pyramation
Copy link
Collaborator

hey @MbBrainz you can help by giving me a template/sketch of the changes, see our fixture here

https://github.com/CosmWasm/ts-codegen/blob/main/__output__/sg721/Sg721.react-query.ts

I'm also thinking we should rename the feature/option from react-query to tanstack #143

@MbBrainz
Copy link
Author

MbBrainz commented Apr 19, 2024

@pyramation I made the necessary changes to sg721.react-query.ts to be compatible with tanstack/react-query@5.x in this pull request. I installed that dep locally and checked the types. This should be completely functional.

In case anything is not clear, the migration guide migrating-to-v5 is very helpful.

@MbBrainz
Copy link
Author

@pyramation checkout my template sketch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants