Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mebibytes As Universal Base Storage Unit #71

Open
1 task done
ericwang401 opened this issue Jan 15, 2024 · 0 comments
Open
1 task done

Use Mebibytes As Universal Base Storage Unit #71

ericwang401 opened this issue Jan 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ericwang401
Copy link
Collaborator

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

Currently, Convoy stores storage units as mebibytes in the database (because of the max integer limit with MySQL's integer datatype) and converts it back to bytes when interacting with the value. This conversion can cause a little confusion and has a little bit of the mental overhead.

One such example is the frontend where users input mebibytes instead of bytes–inputting bytes is ridiculous given the large quantity of storage and memory nowadays. The developer has to remember to convert between the two values, and it's absolutely annoying and can lead to bugs.

Since absolutely no one uses bytes, mebibytes should be used throughout all the code.

Describe the solution you'd like.

Remove the byte to mebibyte and vice versa conversion.

Additional context to this request.

No response

@ericwang401 ericwang401 added the enhancement New feature or request label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant