Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessarily strict requirement for batch size in MASPlugin #1548

Open
niniack opened this issue Dec 15, 2023 · 1 comment
Open

Unnecessarily strict requirement for batch size in MASPlugin #1548

niniack opened this issue Dec 15, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@niniack
Copy link
Contributor

niniack commented Dec 15, 2023

Describe the bug

In the MASPlugin, the following check seems to be unnecessarily strict:

Link to code

for _, batch in enumerate(dataloader):
    # Get batch
    if len(batch) == 2 or len(batch) == 3:
        x, _, t = batch[0], batch[1], batch[-1]
    else:
        raise ValueError("Batch size is not valid")

As a result, if I have a custom dataset which returns additional elements (two images and a label), thi

Expected behavior

I am not sure MAS needs to follow this check, it can simply grab the needed information (image, label, and token) and continue onwards.

@niniack niniack added the bug Something isn't working label Dec 15, 2023
@ghost

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant