feat: Escape log_comment in query #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a regex that matches any SETTINGS log_comment in a query, and ensures that SETTING is removed. Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
Blokje5
force-pushed
the
feat/escape-log-comment-in-query
branch
from
4771f77
to
6852b8a
Compare
|
I'm closing the PR for the moment since the given solution is not good enough in terms of performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a regex that matches any SETTINGS log_comment in a query, and ensures that SETTING is removed.
Fixes #314
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments