Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was the bitcore-lib removed in 3.0.0 and added again in 3.0.1? #214

Closed
marcoskubis opened this issue Dec 6, 2018 · 6 comments · May be fixed by #215
Closed

Why was the bitcore-lib removed in 3.0.0 and added again in 3.0.1? #214

marcoskubis opened this issue Dec 6, 2018 · 6 comments · May be fixed by #215

Comments

@marcoskubis
Copy link

marcoskubis commented Dec 6, 2018

In the release notes of the version 3.0.0, the bitcore-lib was removed (last line):
image

Why bitcore-lib was removed in 3.0.0 and added again in 3.0.1? This commit
It is conflicting with bitcore-mnemonic, that also requires bitcore-lib:

image
(electron app)

@marcoskubis marcoskubis changed the title Why bitcore-lib was removed in 3.0.0 and added again in 3.0.1? Why was the bitcore-lib removed in 3.0.0 and added again in 3.0.1? Dec 6, 2018
@dividezero
Copy link

dividezero commented Dec 6, 2018

From my investigations, the key cause is in the new 1.7.0 version of bitcore-mnemonic.
screenshot 2018-12-04 at 3 44 39 pm

Specifically this commit
bitpay/bitcore-mnemonic@3ddf49e

If we change lightwallet's bitcore-mnemonic dependency for it to retain 1.5.0 (by just removing the caret in package.json) it wouldn't be an issue

drmartinberger pushed a commit to itp-world/blockchain-otc-dapp that referenced this issue Dec 10, 2018
@ameensol
Copy link

I just ran into this error as well.

@theomarshanti
Copy link

PR that solves it is here: #215

@sameepsi
Copy link

Any updates on this PR?

@sameepsi
Copy link

Looks like this project is no longer updated

@miladmostavi
Copy link
Contributor

This was resolved in 4.0.0.

cameel added a commit to cameel/safe-contracts that referenced this issue Nov 27, 2020
- Version 3.0.1 has a bug that causes multiple copies of bitcore-lib to be installed (Consensys/eth-lightwallet#214) and bitcore-lib does not like that and fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants