Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library a dead-end? Or will it be updated to work with web3.js 1.0? #206

Open
Muhammad-Altabba opened this issue Jul 9, 2018 · 6 comments

Comments

@Muhammad-Altabba
Copy link

No updates for this repository since early 2018. And too many issues opened in addition to Pull Requests since 2016.
Is this a dead-end? If not, when will it be updated to work with Web3.js version 1.0?
Thanks,

@Muhammad-Altabba
Copy link
Author

Muhammad-Altabba commented Jul 11, 2018

Hello @pelle, @atoulme, @roderik, @mroth and @tcoulter,
Your input is valuable.
Many thanks,

@atoulme
Copy link

atoulme commented Jul 11, 2018

Hi @Muhammad-Altabba, thank you for your inquiry. How much work do you think moving to web3.js 1.0 will consist of? Would you like to place a bounty on this task, or provide a patch?

@Muhammad-Altabba
Copy link
Author

Muhammad-Altabba commented Jul 11, 2018

Hi @atoulme ,
Thanks for your response.
Actually, I am not sure about that. Could you help by providing in brief, or preferably in details, the places where do you think the modifications are needed? So, based on that, I can do some research regarding...
Many Thanks,

@atoulme
Copy link

atoulme commented Jul 12, 2018

I downloaded the code and performed the upgrade. With a few changes - that were helpfully already commented - I made all tests pass locally with the latest web3 build.
I have pushed the commit to a branch of mine: atoulme@64c13f4

Now starts your part. Please review the changes, make sure everything works OK, open a PR with them and make sure it lands on master on this repo.

@Muhammad-Altabba
Copy link
Author

Hello @atoulme,
It is working well. I made the pull request: #212.
Sorry that I was extremely busy finalizing some other things.

@Muhammad-Altabba
Copy link
Author

Hi @atoulme,
Do you like to accept the pull request #212 and close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants