Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example/webwallet #204

Open
lerennardleonard opened this issue May 31, 2018 · 0 comments
Open

Example/webwallet #204

lerennardleonard opened this issue May 31, 2018 · 0 comments

Comments

@lerennardleonard
Copy link

Hi,
first thank you for the awesome work !
I'm working with your lightwallet in order to make an atomic swap ready light wallet.
Trough my research I've found some issues in this file https://github.com/ConsenSys/eth-lightwallet/blob/master/example/webwallet.html

I think there is an html error on the example/webwallet.html
The problem is that at line 165 and 175, both inputs have the same id (id="sendValueAmount")
Therefore, there is a conflict between both inputs resulting in any transaction towards a contract having a value of 0.
Moreover, there is an other problem with arguments passing towards the contract. They are JSON parsed but they shouldn't. The call to a contract's function expects a javascript array.
I'll be glad to help by making a pull request of an updated file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant