New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should tokenCount 0 return true, false, or throw? #33

Open

ethers opened this issue Jul 27, 2016 · 0 comments

Collaborator

ethers commented Jul 27, 2016

Currently the behavior for all the following is to execute code and return true:

https://github.com/ConsenSys/singulardtv-contracts/blob/66f00bfa775aab9b9852c35e0406037fca42495e/contracts/SingularDTVCrowdfunding.sol#L142

https://github.com/ConsenSys/singulardtv-contracts/blob/66f00bfa775aab9b9852c35e0406037fca42495e/contracts/SingularDTVToken.sol#L89

https://github.com/ConsenSys/singulardtv-contracts/blob/66f00bfa775aab9b9852c35e0406037fca42495e/contracts/SingularDTVToken.sol#L80

It seems fine and leads to less source code; I'll look if this goes against any recommended security principles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment