This repository has been archived by the owner on Apr 23, 2019. It is now read-only.
Give SSZ#merkleHash Public Visibility for Compatibility #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it's exposed publicly, it's worth adding more error checking to the method itself. E.g. validate the argument is not null, and probably check that all list elements are of the same size. |
|
Makes sense, I'll look through it once more and add some sensible error checks. |
schroedingerscode
force-pushed
the
feat/public-visibility-for-ssz-merkleHash
branch
from
1461f5c
to
29ebdc9
Compare
schroedingerscode
force-pushed
the
feat/public-visibility-for-ssz-merkleHash
branch
from
29ebdc9
to
34722c6
Compare
|
Going to close this for now. Please reopen if you would like to see this come through. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the visibility of
SSZ#merkleHashto be public, which allows compatibility and ease of implementation with some versions of the Eth2 Beacon Chain spec. More details are provided in the linked issue.Resolves #197