Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concordia] Improve rate limiting #111

Open
abizjak opened this issue Sep 10, 2023 · 1 comment
Open

[Concordia] Improve rate limiting #111

abizjak opened this issue Sep 10, 2023 · 1 comment
Labels
[Type] Task An additional feature or improvement.

Comments

@abizjak
Copy link
Member

abizjak commented Sep 10, 2023

Task description

The issuers have basic rate limiting now that is not persisted across restarts of the issuer services.

See #84

To make this more robust we should add a persistent rate limit.

@abizjak abizjak added the [Type] Task An additional feature or improvement. label Sep 10, 2023
@mh-concordium
Copy link

With the current solution, after 5 credentials were issued, user can try to issue new ones and after selecting "ADD" in bw, user will see the alert in teh frontend while the credentials will appear in the wallet being in Pending state "forever".

Proper solution would be to check whether there are already 5 credentials issued for the user id (Telegram/Discord) and then if that would be true, throw an error in the frontend while bw would not open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Development

No branches or pull requests

2 participants