Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SchemaType implementation of OnReceivingCis2DataParams<T, A, D> #426

Merged
merged 1 commit into from Apr 30, 2024
Merged

Fix SchemaType implementation of OnReceivingCis2DataParams<T, A, D> #426

merged 1 commit into from Apr 30, 2024

Conversation

lassemoldrup
Copy link
Contributor

Purpose

Closes #420.

Changes

Added a manual implementation of SchemaType for OnReceivingCis2DataParams<T, A, D> that matches the Serial and Deserial implementations

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemoldrup
Fix SchemaType implementation of `OnReceivingCis2DataParams<T, A, D…
45ac72f 
…>` so that it matches `Serial` and `Deserial` implementations.
@lassemoldrup lassemoldrup merged commit bdb9b1b into main Apr 30, 2024
153 checks passed
@lassemoldrup lassemoldrup deleted the fix-on-receiving-schema-type branch April 30, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SchemaType for OnReceivingCis2DataParams does not match Serialize implementations
2 participants
@lassemoldrup @limemloh