Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemaType for OnReceivingCis2DataParams does not match Serialize implementations #420

Closed
limemloh opened this issue Apr 19, 2024 · 1 comment · Fixed by #426
Closed

SchemaType for OnReceivingCis2DataParams does not match Serialize implementations #420

limemloh opened this issue Apr 19, 2024 · 1 comment · Fixed by #426
Assignees
@lassemoldrup
Labels
[Type] Bug Something isn't working

Comments

@limemloh
Copy link
Collaborator

Bug Description

The derived SchemaType for OnReceivingCis2DataParams does not match the manual Serial and Deserial implementations, since the generic D replacing AdditionalData is missing the length of the data encoded.
@limemloh limemloh added the [Type] Bug Something isn't working label Apr 19, 2024
@limemloh
Copy link
Collaborator Author

limemloh commented Apr 24, 2024 •
edited

The ideal solution would probably be to extend the SchemaType for better support, but since adding support in all of our projects would be a large task, we should for now just manually implement SchemaType for OnReceivingCis2DataParams hardcoding the data field to be SchemaType::ByteList.

@lassemoldrup lassemoldrup self-assigned this Apr 26, 2024
@lassemoldrup lassemoldrup mentioned this issue Apr 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassemoldrup lassemoldrup

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@lassemoldrup @limemloh