Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node is attempting to connect to banned peers #1039

Open
mh-concordium opened this issue Sep 28, 2023 · 1 comment
Open

Node is attempting to connect to banned peers #1039

mh-concordium opened this issue Sep 28, 2023 · 1 comment
Labels
[Type] Bug Something isn't working

Comments

@mh-concordium
Copy link
Contributor

Bug Description
After a peer is banned, looking at the log indicates that the node tries to connect to the banned peer.

Steps to Reproduce

  1. Look at connected peers on the node.
  2. Ban a connected peer concordium-client raw BanNode 54.217.153.40.
  3. Restart the node and observe the log (make sure clearing banned nodes at the restart is not enabled).

Expected Result
The node should not attempt to connect to banned peers.

Actual Result
Looking at the logs indicates that the node keeps trying to connect to the banned peer.
Attempting to connect to 54.217.153.40:8888 (499472e35a3740b3).

Versions

  • Software Version: 6.1.4.
@mh-concordium mh-concordium added the [Type] Bug Something isn't working label Sep 28, 2023
@abizjak
Copy link
Member

abizjak commented Oct 1, 2023

So I think this is just a logging issue (in the sense that logging is not ideal). That line in the logs should be followed by

Refusing to connect to a banned IP

if I understand correctly.

It's not entirely obvious in what direction to change the logging though since the information that it is "attempting" to connect is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants