Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OpenSimCreator/Graphics/* enum metadata functions #790

Open
adamkewley opened this issue Oct 5, 2023 · 0 comments
Open

Refactor OpenSimCreator/Graphics/* enum metadata functions #790

adamkewley opened this issue Oct 5, 2023 · 0 comments

Comments

@adamkewley
Copy link
Collaborator

Broken out from #782

In order to implement settings support in #782, various methods were added that map graphics enums (e.g. MuscleColoringStyle) to metadata structs that contain serializable information like names, and ids.

Refactoring should:

  • Try to name the helper functions more consistently
  • Remove their dependence on reading from an unordered_map<std::string, AppSettingValue> and, instead, on something higher-level, like std::function<std::optional<AppSettingValue const&>(std::string_view)>
  • (so that they are more generic, can be composed more cleanly into a hierarchy, etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant