Update Testing section in Makefile #160
Conversation
|
/retest @Vincent056 fixed up the content images for CI - so we should be good to rerun the e2e tests. |
| @@ -596,20 +596,24 @@ image-to-cluster: image openscap-image namespace openshift-user ## Builds and p | |||
| $(eval IMG = image-registry.openshift-image-registry.svc:5000/openshift/$(APP_NAME):$(TAG)) | |||
| $(eval OPENSCAP_IMAGE = image-registry.openshift-image-registry.svc:5000/openshift/$(OPENSCAP_NAME):$(OPENSCAP_TAG)) | |||
|
|
|||
| .PHONY: e2e-content-images | |||
| e2e-content-images: ## Build the e2e-content-image | |||
| .PHONY: build-e2e-content-images | |||
There was a problem hiding this comment.
I think renamed these targets from build-* because "make build-..." sounded redundant in my head :)
But these are primarily dependencies, so its no big deal.
rhmdnd
force-pushed
the
update-make-testing-section
branch
from
61e1fa0
to
67ce48e
Compare
|
/retest |
This commit applies some conventions to the targets and documentation in the testing section: - Use single spaces before help text (results in shorter lines) - Clarify build and push image targets for content - Add documentatin for prep-e2e - Add e2e target to the testing section - Fix the must-gather target by adding push-must-gather-image Fixes openshift#159
rhmdnd
force-pushed
the
update-make-testing-section
branch
from
67ce48e
to
7d27a76
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-parallel Failure due to issues with image registries, which is affecting more than just our project. |
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit applies some conventions to the targets and documentation in
the testing section:
Fixes #159