Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for NotifyCollectionChanged event #298

Open
2 of 29 tasks
michael-hawker opened this issue Dec 7, 2023 · 0 comments
Open
2 of 29 tasks

Better support for NotifyCollectionChanged event #298

michael-hawker opened this issue Dec 7, 2023 · 0 comments
Labels
enhancement New feature or request feature request 📬 A request for new changes to improve functionality good first issue Good for newcomers help wanted Extra attention is needed

Comments

@michael-hawker
Copy link
Member

Describe the bug

We have 6 explicit places we reference the NotifyCollectionChanged event in the Toolkit: https://github.com/search?q=repo%3ACommunityToolkit%2FWindows%20NotifyCollectionChanged&type=code

  • MetadataControl - Updates everything all the time regardless
  • WrapLayout/StaggeredLayout - Does something with Indexes? Probably need update?
  • IsNullOrEmptyStateTrigger - Just uses it as an indicator to check collection size, so should be good
  • InterspersedObservableCollection (TokenizingTextBox) - Looks like it handles multiple changes already, but could probably use tests for this scenario? (Actually, looks like we didn't bring their original test file forward from the old repo ☹)
  • AdvancedCollectionView - if more than one resets the collection, so doesn't care, but un-optimal

If/When dotnet/runtime#18087 gets implemented, it'd be good for the Toolkit to just be ready and work. Many of our other collection controls are just based on ListViewBase and don't do anything too special, so I think we should be good other from the above?

Steps to reproduce

N/A

Expected behavior

Should work with multiple items in a collection changed event.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

No, I'm unable to contribute a solution.

@michael-hawker michael-hawker added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed feature request 📬 A request for new changes to improve functionality labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request 📬 A request for new changes to improve functionality good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant