-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ioBroker backend #1379
base: develop
Are you sure you want to change the base?
ioBroker backend #1379
Conversation
cometvisu.code-workspace
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an IDE setting?
I'm not sure whether we want IDE settings in the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a Visual Studio Code project file so you can easily open the project is VS Code. It doesn't contain any settings. Should I keep or remove the project file?
~~~~~~~~ | ||
|
||
Die Installation des "Web socket" Adapters in ioBroker ist nötig. Dieser Adapter | ||
wird der für den Datenaustausch verwendet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Klingt komisch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I recently updated the phrase. Still my preferred solution is a fully self contained package in the ioBroker adapter "store", I'll dig deeper how to get there after solving the diagram implementation. Will update this section then.
General code review, just by looking at the source: the files are looking fine, except two issues. See the individual comments for those. When you think it's ready to merge just give a cheer and I'll test it (with knxd-backend; I cannot test the other backends) |
Thanks for your review @ChristianMayer! For now let's keep this pending as draft until the diagram implementation has been ironed out. I'm moving my own installation to ioBroker as we speak, so I should have some more confidence on the implementation quality in the next couple days. |
- Enable backend autoconfiguration by ioBroker.web extension
This is WIP. Missing stuff:
Fixes #707 and ioBroker/AdapterRequests#86