Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic parameter 'S' shadows generic parameter from outer scope with the same name; this is an error in Swift 6 #165

Open
Aw79 opened this issue Jan 24, 2024 · 0 comments · May be fixed by #166
Open

Generic parameter 'S' shadows generic parameter from outer scope with the same name; this is an error in Swift 6 #165

Aw79 opened this issue Jan 24, 2024 · 0 comments · May be fixed by #166

Comments

@Aw79
Copy link

Aw79 commented Jan 24, 2024

Hello ✌️,

in /Sources/Operators/Internal/Timer.swift there are warnings in func addSubscriber<S: Subscriber>(_ sub: S) and internal func receive<S: Subscriber>(subscriber: S)
like Generic parameter 'S' shadows generic parameter from outer scope with the same name; this is an error in Swift 6.

warning-receive warning-addSubscriber

This can very easily be fixed by renaming the Generics of the methods.

I would like to provide a PR to solve this.

Cheers,
Andy
Aw79 added a commit to Aw79/CombineExt that referenced this issue Jan 24, 2024
@Aw79
CombineCommunity#165: Rename generic parameter from S to T to avoid s…
df29262 
…hadowing generic parameter of outer scope
@Aw79 Aw79 linked a pull request Jan 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Aw79