Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Generic way to control volume regardless of the streaming service #282

Open
doh38 opened this issue Sep 21, 2018 · 3 comments
Open

Generic way to control volume regardless of the streaming service #282

doh38 opened this issue Sep 21, 2018 · 3 comments
Milestone

Comments

@doh38
Copy link

doh38 commented Sep 21, 2018

Description:

I use Kde-connect with your player. This is a neat tool allowing me to control any player from android and actually the main reason I use your player instead of the web page ;)
Nearly everything works EXCEPT the volume control (it works with for example Rythmbox).
I asked the guys from KDE connect and they told me :

"The player volume control is defined in the MPRIS2 specification. Players should adhere to that."

That's now the only issue I have with your player. Kde-Connect will release a "main volume control" soon, and that will solve this issue (I use a workaround currently having recorded terminal command for Vol+ and - from terminal and can then, with a few menu, reach my goal :)
That's said.
*Is it a bug?
*Is there any reason for non compliance?

Steps To Reproduce:

  1. Start player
  2. Start Kde connect
  3. try to change volume from app, not happening ^^

Log Files

/nolog

Additional Information:

  • Version: Last from ppa
  • Affected streaming services (if any): Soundcloud
  • Operating System: 18.04 + Unity + Kde-Connect
@ColinDuquesnoy
Copy link
Owner

Not all streaming service plugins support setting the volume. Soundcloud plugin does not support it yet. Deezer supports it.

Maybe we can see if there could be a generic way to control the QtWebEngine audio level regardless of the streaming service and move that functionality out of plugins. I'll investigate.

@ColinDuquesnoy ColinDuquesnoy changed the title MPRIS2 Compliance Generic way to control volume regardless of the streaming service Sep 21, 2018
@doh38
Copy link
Author

doh38 commented Sep 21, 2018

Thanks Colin! Great to hear :)

@ColinDuquesnoy ColinDuquesnoy added this to the 3.5.0 milestone Oct 21, 2018
@ColinDuquesnoy
Copy link
Owner

This issue has been moved to our new gitlab issue tracker.

The github repository will be archived soon and this issue will become read-only. We suggest you continue the discussion and follow the progress on this issue at gitlab.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants