Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Possibility to overload\redefine tray icon #234

Open
flops opened this issue May 16, 2018 · 5 comments
Open

Possibility to overload\redefine tray icon #234

flops opened this issue May 16, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@flops
Copy link

flops commented May 16, 2018

Description:

It would be great to be able redefine or overload icons for MellowPlayer. In that with case projects like https://github.com/bilelmoussaoui/Hardcode-Tray app will be more seamless in system.

@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented May 17, 2018

I am not sure I understand the relation with Hardcode-Tray.

From what I understand (and correct me if I am wrong), Hardcode-Tray is a tool for fixing hardcoded tray icons. So it should be used on program where you can't change the tray icon such as the current version of MellowPlayer.

If I understand your feature request right, you won't need Hardcode-Tray anymore once this feature is complete since you will be able to change the tray icon from MellowPlayer's settings.

@ColinDuquesnoy ColinDuquesnoy added this to To Do in MellowPlayer 3 via automation May 17, 2018
@ColinDuquesnoy ColinDuquesnoy added this to the 3.4.0 milestone May 17, 2018
@ColinDuquesnoy ColinDuquesnoy self-assigned this May 17, 2018
@flops
Copy link
Author

flops commented May 17, 2018

Oh i get it. I thought that there would be a default path it's useful cause when you switching icon theme, apps icons is changing accordingly to it.
Honestly it would be great to have that path, for example in ~/.config/MellowPlayer/tray.png, cause in future it could have pause\play state icons.
Sorry if i'm asking lot. And thank you for your work.

@ColinDuquesnoy ColinDuquesnoy added this to To do in 3.4 May 31, 2018
@ColinDuquesnoy ColinDuquesnoy modified the milestones: 3.4.0, 3.5.0 Jun 3, 2018
@ColinDuquesnoy ColinDuquesnoy removed this from To do in 3.4 Jun 3, 2018
@ColinDuquesnoy ColinDuquesnoy added this to To do in 3.5 Jun 3, 2018
@varlesh
Copy link

varlesh commented Jul 30, 2018

Current icons worked fine without hardcode-tray on plasma desktop:
image
QSystemTrayIcon used icons from plasma theme (if available) :)

@ColinDuquesnoy
Copy link
Owner

Thank you for confirming this works on Plasma.

This feature could still be useful for other desktops/platform though...

@ColinDuquesnoy
Copy link
Owner

This issue has been moved to our new gitlab issue tracker.

The github repository will be archived soon and this issue will become read-only. We suggest you continue the discussion and follow the progress on this issue at gitlab.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
3.5
  
To do
MellowPlayer 3
  
To Do
Development

No branches or pull requests

3 participants