Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new optional param to [p]muteset senddm for auto unmute dm #6366

Closed
wants to merge 1 commit into from
Closed

Added new optional param to [p]muteset senddm for auto unmute dm #6366

wants to merge 1 commit into from

Conversation

turbo-jayce
Copy link

@turbo-jayce turbo-jayce commented Apr 25, 2024 •
edited by Flame442

Description of the changes

  • Added a new variable dm_auto_unmute as a toggle
  • senddm has new optional parameter that can toggle dm's off for auto unmutes
  • if parameter isnt specified it will default to value inputted to setdm
  • allows for dm's to be sent for mutes, and no dm's sent for when they are automatically unmuted

Have the changes in this PR been tested?

No

Additional Notes

This is my first PR to repo and unsure if this is the proper way to go about this.

Issue

Closes #6262

@github-actions github-actions bot added the Category: Cogs - Mutes This is related to the Mutes cog. label Apr 25, 2024
@Flame442 Flame442 added the Type: Enhancement Something meant to enhance existing Red features. label Apr 25, 2024
@Flame442
Copy link
Member

I know this is still a draft, but here's some tips about what is currently missing to get you on the right track:

  • You need to make a config call to get the value of dm_auto_unmute before it can be used as a value.
    • It might make sense to move these checks within _send_dm_notification by adding a parameter specifying whether it was called for an auto unmute or a manual unmute.
  • Rather than adding to the existing command, you should probably make a separate command for configuring this new setting.
  • You need to use the black autoformatter to style the updated code, in accordance with the CONTRIBUTING.MD file.

@Kowlin
Copy link
Member

Kowlin commented May 2, 2024

Due to the lack of activity on this PR, I'm gonna go ahead and close this.

@Kowlin Kowlin closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrustyJAID TrustyJAID Awaiting requested review from TrustyJAID TrustyJAID will be requested when the pull request is marked ready for review TrustyJAID is a code owner

Assignees
No one assigned
Labels
Category: Cogs - Mutes This is related to the Mutes cog. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate muteset senddm for mutes and unmutes
3 participants
@turbo-jayce @Flame442 @Kowlin