Skip to content
This repository has been archived by the owner on Jul 5, 2022. It is now read-only.

166 ASCII Image: charIndex out of bounds for white pixels #3633

Open
jogerj opened this issue May 12, 2022 · 1 comment
Open

166 ASCII Image: charIndex out of bounds for white pixels #3633

jogerj opened this issue May 12, 2022 · 1 comment

Comments

@jogerj
Copy link

jogerj commented May 12, 2022

in sketch.js, the charIndex of a pixel is calculated as follows:
const charIndex = floor(map(avg, 0, 255, 0, len));
Instead, it should be
const charIndex = floor(map(avg, 0, 256, 0, len));
because otherwise whites (rgb 255, 255, 255) will be mapped to the exact length of the density string which returns '' (an empty string) instead. This results in tearing on videos. The tricky bit was charAt didn't report any error when accessing out of bound index so it went unnoticed.

Nice tutorial btw

@KobeLiesenborgs
Copy link
Collaborator

Hi Jogerj!

Thank you for submitting this errata! You can make a pull request for the fix if you want to!
We'll be moving to a new website soon so if this issue is still open when we move I'll add the fix myself!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants