Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default password must be changed on the first access #121

Open
avivace opened this issue Feb 5, 2019 · 2 comments
Open

The default password must be changed on the first access #121

avivace opened this issue Feb 5, 2019 · 2 comments

Comments

@avivace
Copy link
Member

avivace commented Feb 5, 2019

Having the same password for every device is a serious security issue (webcam stream, ...)

(1)
I propose to disable every route and make the web application unusable until the password is changed.

On the backend:

  • Implement a change wifi password route
  • check the password, if it's the default, disable every route but the change wifi password one, then force a redirect to a change password page on the frontend

On the frontend:

  • Implement a simple page allowing to change the password

(2)
An alternative could be to generate a new password, show it to the user, making sure the user has taken note of (confirmation dialog?) then reboot the wifi service and apply the new password, on the first run.

Any opinion on this? @previ @leonardo77

@leonardo77
Copy link

(1) seems ok to me, but we also need the possibility to reset the password. If we add a hardware button we can exploit it to trigger the password reset, assuming that anyone who has the access to the robot can set its password.

@previ
Copy link
Contributor

previ commented Feb 6, 2019

Agree, (1) looks good to me.
The password, as well as the ssid, could be changed via web ui, old version.
It implemented in wifi.py; it's a little cumbersome, but it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants