This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Fix: allocation chart sorting by user name #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielRMuller
approved these changes
Apr 5, 2023
adbatista
added a commit
that referenced
this pull request
May 29, 2023
This reverts commit 547c030.
adbatista
added a commit
that referenced
this pull request
May 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373
The previous code inside
app/assets/javascripts/active_admin/allocation_chart.jswas defining a rule fornamecolumn to be sorted based onhiddenTimecolumn. This fix removes the rule to allownamecolumn to sort user names correctly.