-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Github API authentication #18
Comments
do we have any intention to support this capability? |
Thanks for reporting this issue and sorry for the late reply. Potential SolutionsI came up with the following solutions: Authenticated RequestsUse unauthenticated requests until we hit the rate limit.
Pros
Cons
gitignore Template Web ServiceCreate a simple web service that
Pros
Cons
ConculsionBoth solutions could be implemented as gitignore providers. This would allow the user to choose the provider that best suits its setup using a provider selection dropdown in the extension settings. @rlivings39 @tyler-8 @jimmyharris @jamesharris-garmin |
I don't think closing every vscode window and relaunching from a terminal with a manually created token is a great solution to this issue. It seems like even more work for the user than the first suggestion about OAuth token storage. VSCode already has a system for handling GitHub authorizations. Which is used by the "GitHub Pull Requests and Issues", GitLens, and other VSCode extensions. Which the user will often already be signed in to and if not only needs to be setup once (the env var needs to be re-done every time in the future you start a project and need a .gitignore). I think this should just be used if the user hits the unauthenticated limit. |
Thanks for you feedback @dantman. I fully agree with you that environment variables are rather inconvenient. I took a look the the "new" authentication providers introduced in July 2020 with version 1.48 and decided to try this approach. I'm currently working on a prototype that uses the following strategy:
Will keep you posted. |
Was there any progress on using the authentication providers? (been a while) |
I recieved this error today while trying to pull down a gitignore file:
403: {"message":"API rate limit exceeded for <MY-IP>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://developer.github.com/v3/#rate-limiting"}
So in environments where a lot of users might be behind one IP address (corporate proxy as an example) the unauthenticated API limits can be hit somewhat regularly. Perhaps using the locally configured git credentials would a good way around this.
The text was updated successfully, but these errors were encountered: