Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style guide violation, please update #570

Open
SallyMcGrath opened this issue Jan 14, 2023 · 7 comments
Open

Style guide violation, please update #570

SallyMcGrath opened this issue Jan 14, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@SallyMcGrath
Copy link
Member

const arr = [1, 2, 3];

const newArr = arr.concat(4);

Improper use of arr, newArr
https://syllabus.codeyourfuture.io/guides/code-style-guide

Please update to follow our own advice

@SallyMcGrath SallyMcGrath added the good first issue Good for newcomers label Jan 14, 2023
@MohitBansal321
Copy link

i can you assgin this issue to me

@MohitBansal321
Copy link

okay i will replace it with this
const array=[1,2,3];
const newArray=array.concat(4);

@MohitBansal321
Copy link

i created pull request

@SallyMcGrath
Copy link
Member Author

Hi @MohitBansal321 . You can connect tickets and PRs on GitHub with a hashtag. Type #572 here or on your PR type fixes #570

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@MohitBansal321
Copy link

#572

@MohitBansal321
Copy link

I done the changes
let me know is it okay

@MohitBansal321
Copy link

MohitBansal321 commented Jan 16, 2023

@SallyMcGrath
Hey I am not getting any feedback from you
kindly respond me so i can work on another issues here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Status: In progress
Development

No branches or pull requests

2 participants