Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style guide violation, please update #569

Open
SallyMcGrath opened this issue Jan 14, 2023 · 4 comments
Open

Style guide violation, please update #569

SallyMcGrath opened this issue Jan 14, 2023 · 4 comments
Assignees
@MohitBansal321
Labels
good first issue Good for newcomers

Comments

@SallyMcGrath
Copy link
Member

syllabus/docs/workshops/js-testing-workshop.md

Line 54 in 02da63d

var result;

Improper use of var

https://syllabus.codeyourfuture.io/guides/code-style-guide

Please update to follow our own advice
@SallyMcGrath SallyMcGrath added the good first issue Good for newcomers label Jan 14, 2023
@MohitBansal321
Copy link

what can we use instead of var?

@SallyMcGrath
Copy link
Member Author

what can we use instead of var?

let

@MohitBansal321
Copy link

i created a pull request

@MohitBansal321 MohitBansal321 mentioned this issue Jan 15, 2023
Closed
@MohitBansal321
Copy link

I changed all var to let according to style guide @SallyMcGrath
please let me know how is it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitBansal321 MohitBansal321

Labels
good first issue Good for newcomers
Projects
No open projects
Syllabus Planning ARCHIVED
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SallyMcGrath @MohitBansal321