Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch L9-Start wrong values in inStock() #22

Open
amouratoglou opened this issue Jan 16, 2021 · 3 comments
Open

Branch L9-Start wrong values in inStock() #22

amouratoglou opened this issue Jan 16, 2021 · 3 comments

Comments

@amouratoglou
Copy link

amouratoglou commented Jan 16, 2021

Hey guys, great tutorial!!

I have noticed that L9-Start , which should have the finished code of L8, on main.js line 30 it doesn't have the right value on the computed property inStock(). It is set to look for the property image
instead of quantity

This might be confusing and frustrating for some users that need to compare their code with finished code and also, doesn't allow starting the lesson with fully working code.

https://github.com/Code-Pop/Intro-to-Vue-3/tree/L9-start

Current code:

        inStock() {
            return this.variants[this.selectedVariant].image
        }

Correct code:

        inStock() {
            return this.variants[this.selectedVariant].quantity
        }

Is there any way to contribute to the repo?

thanks

@amouratoglou amouratoglou changed the title Branch L9-Start Branch L9-Start wrong values in inStock() Jan 16, 2021
@michaelbutler
Copy link

Nice find! Looks like this was fixed in this Pull Request: #4
I hope it gets merged! Though it was a good exercise in debugging to try to find the problem.

@Syns369
Copy link

Syns369 commented Aug 25, 2021

Hi, It seems that the error has not been corrected.

@Naude555
Copy link

Naude555 commented Feb 8, 2022

Still waiting on this error to be corrected. Also picked it up today more than a year later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants