Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user registering for a server, when registration fails, I would like the valid registration input fields not to be cleared so that I do not have to reenter everything #4982

Open
candyapplecorn opened this issue Jan 12, 2024 · 0 comments · May be fixed by #4983
Open

As a user registering for a server, when registration fails, I would like the valid registration input fields not to be cleared so that I do not have to reenter everything #4982

candyapplecorn opened this issue Jan 12, 2024 · 0 comments · May be fixed by #4983
Labels
Feature Request

Comments

@candyapplecorn
Copy link

Description of New Feature

When using the registration feature, the user may have their registration rejected because they might be using invalid characters in a name, or their name might already be taken. When does happens, the user is sent back to the registration input flow. However, all of the fields except for the server name and the server port are cleared. It would be nice if they were not cleared, so that the user only had to fix the single input field that was invalid and caused the registration rejection in the first place.

This new feature would simply keep the valid input fields' data.
@candyapplecorn candyapplecorn changed the title As a user registering for a server, when registration fails, I would like the registration input fields not to be cleared that I do not have to reenter everything As a user registering for a server, when registration fails, I would like the registration input fields not to be cleared so that I do not have to reenter everything Jan 12, 2024
@candyapplecorn candyapplecorn changed the title As a user registering for a server, when registration fails, I would like the registration input fields not to be cleared so that I do not have to reenter everything As a user registering for a server, when registration fails, I would like the valid registration input fields not to be cleared so that I do not have to reenter everything Jan 12, 2024
candyapplecorn added a commit to candyapplecorn/Cockatrice that referenced this issue Jan 13, 2024
@candyapplecorn
Modify dlg register to accept optional arguments for previous registr…
920fdf2 
…ation inputs (Cockatrice#4982)
@candyapplecorn candyapplecorn linked a pull request Jan 13, 2024 that will close this issue
Open
candyapplecorn added a commit to candyapplecorn/Cockatrice that referenced this issue Jan 13, 2024
@candyapplecorn
Made DlgRegister a friend class of AbstractClient so that it can
ddf8487 
access user input in case registering to a server fails and the
user is sent back to the registration input dialogue again. This
saves the user the effort of re-typing everything, when presumably
only one thing is incorrect

Adds the feature requested from issue Cockatrice#4982

See Cockatrice#4983 for more information
This was referenced Jan 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remember user inputs after failed registration #4982 candyapplecorn/Cockatrice
1 participant
@candyapplecorn