Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you add support for openrc? #266

Open
custom82 opened this issue Dec 6, 2020 · 9 comments
Open

can you add support for openrc? #266

custom82 opened this issue Dec 6, 2020 · 9 comments

Comments

@custom82
Copy link

custom82 commented Dec 6, 2020

No description provided.

@tomjelinek
Copy link
Member

I suppose you are asking about a possibility to manage resources implemented as OpenRC services, as an alternative to SystemV init scripts, Upstart or Systemd. If that is the case, then adding support for that does not really depend on pcs. It is pacemaker who needs to be able to run OpenRC scripts. Then pcs should be able to manage them without significant code changes as it reads all information about resource agents from pacemaker.

@kgaillot Is OpenRC supported by pacemaker? Are there any plans in this matter? Thanks.

@custom82
Copy link
Author

custom82 commented Dec 8, 2020

pcs currently executes systemd or chkconfig | commands to check the status of cluster daemons service (red hat), I was wondering if it was possible to make him run openrc rc-config and rc-service commands

@tomjelinek
Copy link
Member

Thank you for clarification.

Currently, we have no plans for adding OpenRC support into pcs. However, we will consider merging a pull request if there is one.

@custom82
Copy link
Author

custom82 commented Dec 8, 2020

this means that users of Gentoo, Alpine etc etc cannot use pcs

@custom82
Copy link
Author

Thank you for clarification.

Currently, we have no plans for adding OpenRC support into pcs. However, we will consider merging a pull request if there is one.

this is my openrc patch!
https://github.com/gentoo-mirror/guru/blob/master/sys-cluster/pcs/files/openrc-0.10.7.patch

@OndrejHome
Copy link

Hi Tom @tomjelinek ,
I might have a look at proposing the PR in future once I get through some other higher priority things ;)

For anyone looking into this and wondering how hard it could be, feel free to check following small (~4kB) patches that worked for me with pcs-0.10.2 and pcs-0.10.7 on Gentoo. Note that on systemd version of Gentoo you don't need those patches as it behaves as any other systemd system in regards to services, other system specific patches are needed.
And yes, if you feel like doing it you can have single cluster with nodes using systemd and nodes using openrc on Gentoo.

https://github.com/OndrejHome/ondrejhome-gentoo-overlay/blob/pcs-0.10.7/sys-cluster/pcs/files/openrc-0.10.2.patch
https://github.com/OndrejHome/ondrejhome-gentoo-overlay/blob/pcs-0.10.7/sys-cluster/pcs/files/openrc-0.10.7.patch

@tomjelinek
Copy link
Member

Hi @custom82 and @OndrejHome,

Thank you for the patches. I briefly read through them and they look reasonable. Custom82 even provided tests, which is great.

We are currently in a process of transitioning to autotools, which will allow us to add support for various Linux distros and their differences more easily. Therefore, I think it makes sense to postpone integrating your patches until the autotools transition is finished. Depending on how the transition proceeds, we may even integrate your patches as a part of it. We'll see once we get to that point.

@custom82
Copy link
Author

custom82 commented Apr 1, 2022

any news?

@tomjelinek
Copy link
Member

@custom82 Can you test #498 and report back if it works? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants