Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: crm conf primitive should complain when an ra-package not installed #967

Open
aleksei-burlakov opened this issue May 5, 2022 · 5 comments

Comments

@aleksei-burlakov
Copy link

When doing
crm configure primitive st-ssh stonith:external/ssh params hostlist=node1
the crm would complain
ERROR: st-ssh: parameter "hostlist" is not known
(because the libglue-devel containing stonith:external/ssh was not installed). The user would rather get the message that stonith:external/ssh or libglue-devel was not installed, than that the parameter "hostlist" is not known.

@aleksei-burlakov aleksei-burlakov changed the title wishlist: crm conf primitive complains should complain that a package not installed wishlist: crm conf primitive should complain when an ra-package not installed May 5, 2022
@liangxin1300
Copy link
Collaborator

liangxin1300 commented May 9, 2022

@aleksei-burlakov Thanks for pointing this!
IMO, maybe crmsh can maintain a map for most used RA, to show which package name that this RA is belonged?
OTOH, does resource-agent already have such a map?
@zzhou1 @gao-yan What do you think? Good to append to the feature list for next release?

@zzhou1
Copy link
Contributor

zzhou1 commented May 10, 2022

Agree, this Use case is valid to improve User Experience. From the design wise, the code could be generic and flexible to avoid maintenance burden if any. We could add it to the backlog to do further assessment if possible make it to the next release.

@liangxin1300
Copy link
Collaborator

liangxin1300 commented May 10, 2022

OTOH, does resource-agent already have such a map?

I think it's hard for resource-agent to maintain such a RA-name:package-name map, since for different vendor the package name is different

@aleksei-burlakov
Copy link
Author

Maybe, just tell the user the package is not installed, and let him find out which one himself.

@liangxin1300
Copy link
Collaborator

I think for most of RA, exitreason from crm_mon can give more details

Although not for this stonith:external/ssh RA:

* st-ssh_start_0 on hanode1 'error' (1): call=26, status='complete', last-rc-change='Mon Nov 14 09:11:19 2022', queued=0ms, exec=1226ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants