Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strengthen the error handling of sbd dump during the joining procedure #928

Open
zzhou1 opened this issue Jan 18, 2022 · 1 comment
Open

Strengthen the error handling of sbd dump during the joining procedure #928

zzhou1 opened this issue Jan 18, 2022 · 1 comment

Comments

@zzhou1
Copy link
Contributor

zzhou1 commented Jan 18, 2022

Once I hit the error at the 2nd node when join, when the system disk is busy and has temporary access error in the test environment. I wonder the code could be slightly more robust if possible, instead of fail "easily" here. I don't think this happens often. Well, some code review might help strengthen the error handling.

Jan 17 16:38:43 tw2 crmsh.ui_context: ERROR: cluster.join: Failed to run "sbd -d /dev/disk/by-partlabel/sbd-tw dump": ==Header on disk /dev/disk/by-partlabel/sbd-tw NOT dumped
sbd failed; please check the logs.
@liangxin1300
Copy link
Collaborator

How to reproduce this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liangxin1300 @zzhou1