UX: crm config informative check for an advertised parameter

[zzhou1]

During an online conversation and we spent some amount of time to tell the subtle difference and which format is right or wrong for the following two usages:

a) less often usage

primitive p-lvmlockd lvmlockd \
     op start timeout=90 interval=0s \
     op_params syslog_priority=debug \
     op stop timeout=100 interval=0s \
     op monitor interval=30 timeout=90

b) the more common usage

primitive p-lvmlockd lvmlockd \
     params syslog_priority=debug \
     op start timeout=90 interval=0s \
     op stop timeout=100 interval=0s \
     op monitor interval=30 timeout=90

With some more digging and exercise, I see the tricky difference. params is at the primitive level which applies to all operations. While, op_params at the operation level, can be different among different operations.

To reduce the confusion and improve the user experience and efficiency, it would be nice to provide the following message and ask the user for manual confirmation for scenario a), for example,

"""
NOTICE: syslog_priority is an advertised parameter. Usually, it can be specified in params of primitive. However, it appears in op_params. Please double check. For more details, please refer to: crm configure help primitive
Do you still want to commit (y/n)?
"""

[liangxin1300]

@zzhou1
I see what you mean for the most.
BTW, what do you mean advertised parameter here? syslog_priority is a parameter, but it's not a mandatory one (no required=1)