Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate summerwind/actions-runner #355

Open
quad opened this issue May 24, 2023 · 1 comment
Open

Investigate summerwind/actions-runner #355

quad opened this issue May 24, 2023 · 1 comment

Comments

@quad
Copy link
Contributor

quad commented May 24, 2023

The runner images are all manually constructed images. summerwind/actions-runner about as close to an official runner image as exists.

@kichik
Copy link
Member

kichik commented May 25, 2023

I don't think we will be able to use the image itself, especially if it's under a non-official owner like summerwind. But it did teach me about hooks which may come useful one day.

The exit hook would be nice if it had access to the job result so we can get rid of the log grepping hack.

We might also be able to simplify the idle reaper by giving it the runner id and actual startup time directly from .runner. That said, I don't want to give the runner context permissions to do that as it might get abused by untrusted jobs.

https://github.com/actions/actions-runner-controller/blob/8afef51c8bb4558746eb36fc3f0ad9fd921d0b13/runner/startup.sh#L123-L132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants