Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The .csproj rewriting is a bit too eager in removing nodes #7

Open
kcragin opened this issue Dec 8, 2017 · 0 comments
Open

The .csproj rewriting is a bit too eager in removing nodes #7

kcragin opened this issue Dec 8, 2017 · 0 comments

Comments

@kcragin
Copy link

kcragin commented Dec 8, 2017

I wasn't able to build after upgrade because C# targets were removed by your .csproj rewriter:

  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />

It looks like this bit of code in NuGetUpgraderPackage.cs:

186    //RWM: Remove any Package Targets. 
187    targets.Where(c => c.Attribute("Project").Value.Contains(row.Attribute("id").Value)).ToList() 
188           .ForEach(c => c.Remove()); 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant