Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Fix: TS error declared but never read #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidSint
Copy link

@DavidSint DavidSint commented May 3, 2022

When noUnusedParams is enabled, errors are found e.g. error TS6133: 'req' is declared but its value is never read.. This commit adds an _ before these variable names as requested by @woozie.

resolves #95

@CLAassistant
Copy link

CLAassistant commented May 3, 2022

CLA assistant check
All committers have signed the CLA.

@zemd
Copy link

zemd commented Jul 1, 2022

Hi! any updates on this fix? @BethGriggs @andrewhughes101 could you release it please?

@DavidSint
Copy link
Author

Hi! any updates on this fix? @BethGriggs @andrewhughes101 could you release it please?

I don't have any updates, but I understand that this package is a bit old now and perhaps should be archived.

The new guidance for health checks can be found in the node reference architecture which can be found here: https://github.com/nodeshift/nodejs-reference-architecture/blob/main/docs/operations/healthchecks.md

@zemd
Copy link

zemd commented Jul 2, 2022

the package still follows the guidance though, but anyway thanks for you reply 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript | tsconfig.json | noUnusedParameters: true produces errors
3 participants