Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomly add guard pages around columns/PODArrays #61552

Open
tavplubix opened this issue Mar 18, 2024 · 0 comments
Open

Randomly add guard pages around columns/PODArrays #61552

tavplubix opened this issue Mar 18, 2024 · 0 comments
Labels

Comments

@tavplubix
Copy link
Member

It will help to catch bugs like #61547 and results of wrong casts of columns

We have GWP ASAN, but I have never seen it catch something, probably because we have too many allocations in different places, and the chance of adding guard pages around columns is too low

Maybe we don't need a guard page on the left, so it makes sense to allocate a PODArray close to the right boundary of the page, and add a guard page on the right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant