Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .dataset rather than .field_time_serieses? #280

Open
glwagner opened this issue Jun 13, 2022 · 1 comment
Open

Use .dataset rather than .field_time_serieses? #280

glwagner opened this issue Jun 13, 2022 · 1 comment

Comments

@glwagner
Copy link
Member

glwagner commented Jun 13, 2022

I'm wondering if we should replace "field_time_serieses" with "dataset" wherever it appears. I think "dataset" rolls of the tongue better and is also sufficiently distinct from data so that it won't be confused.

Also Oceananigans has a prototype "FieldDataset" designed to represent a group of FieldTimeSeries. It's not used much now, but could be developed further:

https://github.com/CliMA/Oceananigans.jl/blob/main/src/OutputReaders/field_dataset.jl

@adelinehillier
Copy link
Collaborator

That sounds like a good idea. "field_time_serieses" is a lot to type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants